feat: add reusable EmptyState component and adopt across pages#2017
Open
elizabetdev wants to merge 9 commits intomainfrom
Open
feat: add reusable EmptyState component and adopt across pages#2017elizabetdev wants to merge 9 commits intomainfrom
elizabetdev wants to merge 9 commits intomainfrom
Conversation
Extract repeated empty/setup state UI pattern into a shared EmptyState component and adopt it in DBSearchPage and SessionsPage. Made-with: Cursor
Replace ad-hoc inline empty states with the reusable EmptyState component on Alerts, Dashboards, Search, Service Map, Sessions, and Chart Editor pages. Extend EmptyState to support card/default variants, PaperProps, BoxProps, and fullWidth option. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: af48c6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Knip - Unused Code Analysis⚪ No changes detected (0 issues on both main and PR) What is this?Knip finds unused files, dependencies, and exports in your codebase. Run |
Contributor
PR Review✅ No critical issues found. The PR is a clean, well-structured refactoring that introduces a reusable A few minor observations:
|
The container was unintentionally narrowed to 600px for all states. Now only the empty state uses the narrow centered layout while the populated alert list keeps the original wide container. Made-with: Cursor
Contributor
E2E Test Results❌ 2 tests failed • 115 passed • 3 skipped • 1087s
Tests ran across 4 shards in parallel. |
Always apply mx="auto" on default variant instead of conditionally based on maw presence. Remove fragile <br /> from SessionsPage description — natural wrapping via maw is sufficient. Made-with: Cursor
Made-with: Cursor
Replace ad-hoc inline empty states with EmptyState component on Saved Searches and Dashboards list pages. Add vertical centering for empty states using flex layout. Use minHeight instead of height on Dashboards to prevent squishing when content exists. Made-with: Cursor
The title prop has no default value — update agent_docs to match. Made-with: Cursor
The app-content-scroll-container is already viewport-sized with overflowY: scroll. Using 100vh on child pages caused double scrollbars. 100% correctly fills the parent scroll container. Made-with: Cursor
elizabetdev
changed the title
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EmptyStatecomponent with two variants (defaultfor full-page states,cardfor inline/bordered states), optional icon, title, description, and action slot viachildrenagent_docs/code_style.mdheight: 100%instead of100vhfor pages inside the nav layout)Screenshots
Test plan